RFR: 8143014: Access PtrQueue member offsets through derived classes

Jon Masamitsu jon.masamitsu at oracle.com
Tue Nov 17 18:12:20 UTC 2015


Kim,

Looks good although I have one question.  In
http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/src/share/vm/gc/g1/satbMarkQueue.hpp.frames.html

76 using PtrQueue::byte_width_of_index;

http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/src/share/vm/gc/g1/dirtyCardQueue.hpp.frames.html


80 using PtrQueue::byte_width_of_index;


Are the "using" statements actually needed?  Or are they future proofing?

Jon

On 11/15/2015 12:39 PM, Kim Barrett wrote:
> Please review this cleanup of the API for accessing member offset
> information for SATBMarkQueue and DirtyCardQueue.  Clients now access
> the specific queue class information.  In addition, JVMCI now uses the
> same API for obtaining the information as is used by other compilers
> and interpreters.
>
> Also moved the vmStruct declarations for PtrQueue and members to
> vmStructs_g1.hpp, as that class is G1-specific.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8143014
>
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8143014/webrev.00/
>
> Testing:
> JPRT
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20151117/061524dc/attachment.html>


More information about the hotspot-gc-dev mailing list