Request for Review (s) - 8133023: ParallelGCThreads is not calculated correctly

Kim Barrett kim.barrett at oracle.com
Wed Nov 18 17:20:38 UTC 2015


On Nov 18, 2015, at 10:22 AM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
> 
> 
> 
> On 11/17/2015 04:27 PM, Kim Barrett wrote:
>> On Nov 17, 2015, at 6:44 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>>> On 11/17/2015 02:31 PM, Kim Barrett wrote:
>>>> On Nov 17, 2015, at 4:12 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>>>>> http://cr.openjdk.java.net/~jmasa/8133023/webrev.01/
>>>> Shouldn’t the assert be at the beginning of VM_Version::initialize, rather than some distance into it.
>>>> There are some _features-based predicates being called before that assert on line 63:
>>> Yes, that would be good.  What about the guarantee().  Some of the other variables depend on
>>> has_v9().
>> Does anything before the has_v9() guarantee require v9?  It’s not even slightly obvious to me.
>> OTOH, giving up sooner when we’re going to be giving up anyway is probably better.
>> 
> prefetch_copy_interval_in_bytes() and prefetch_scan_interval_in_bytes() at least use has_v9().
> I'll move the guarantee  up to the top also.

Works for me.  I don’t need a new webrev for moving the assert and guarantee to the top of that function.





More information about the hotspot-gc-dev mailing list