RFR (s): 8143252: Clean up G1CollectedHeap interface
mikael.gerdin at oracle.com
Thu Nov 19 08:41:24 UTC 2015
On 2015-11-19 06:01, Derek White wrote:
> This is a small cleanup that:
> * Deletes an undefined method declaration
While you're at it, would you mind removing the following declaration as
1355 // Update mod union table with the set of dirty cards.
1356 void updateModUnion();
1358 // Set the mod union bits corresponding to the given memRegion. Note
1359 // that this is always a safe operation, since it doesn't clear any
1360 // bits.
1361 void markModUnionRange(MemRegion mr);
G1 has never had a mod union table since its integration in the open
source jvm (AFAIK).
> * Renames method to be more descriptive:
> G1CollectedHeap::do_collection() ---> do_full_collection()
Nice to clean up the naming confusion here.
> * Removes unused parameter "word_size" from (newly renamed)
> do_full_collection() and resize_if_necessary_after_full_collection()
> CR: https://bugs.openjdk.java.net/browse/JDK-8143252
> Webrev: http://cr.openjdk.java.net/~drwhite/8143252/webrev.01/
Looks good to me, I don't need to see an updated webrev with the mod
union declarations removed.
> Ran jprt.
> - Derek
More information about the hotspot-gc-dev