RFR: JDK-8143544: Remove CMSCollector::is_cms_reachable()

Srinivas Ramakrishna ysr1729 at gmail.com
Fri Nov 20 19:30:40 UTC 2015


Hi Bengt --

This was code for debugging CMS. Should have been compiled out of product
build (i.e. protected with #ifndef PRODUCT).

If it hasn't been used in a while for debugging CMS crashes, then it's fine
to remove it.
You might want to check with the sustaining folks to see if they have had
occasion to use it recently (like in
the past year or so), and if not then remove it.

The code removal itself looks fine; reviewed.

-- ramki

On Fri, Nov 20, 2015 at 10:27 AM, Bengt Rutisson <bengt.rutisson at oracle.com>
wrote:

>
>
> On 2015-11-20 19:37, Thomas Schatzl wrote:
>
>> Hi,
>>
>> On Fri, 2015-11-20 at 17:37 +0100, Bengt Rutisson wrote:
>>
>>> Hi everyone,
>>>
>>> Could I have a couple of reviews for this small change?
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8143544
>>> http://cr.openjdk.java.net/~brutisso/8143544/webrev.00/
>>>
>>> CMSCollector::is_cms_reachable() is dead code.
>>>
>>>    looks good.
>>
>
> Thanks, Thomas!
>
> Bengt
>
>
>> Thomas
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20151120/9f487a4f/attachment.html>


More information about the hotspot-gc-dev mailing list