RFR: JDK-8143544: Remove CMSCollector::is_cms_reachable()

Bengt Rutisson bengt.rutisson at oracle.com
Tue Nov 24 08:03:21 UTC 2015


Hi Ramki and Thomas,

On 2015-11-20 21:17, Srinivas Ramakrishna wrote:
>
>
> On Fri, Nov 20, 2015 at 11:27 AM, Bengt Rutisson 
> <bengt.rutisson at oracle.com <mailto:bengt.rutisson at oracle.com>> wrote:
>
>
>     ...
>     I'll check with sustaining to see what they think.
>
>
> Cool.

I checked with sustaining. They have not been using this code for quite 
some time but they would like to keep it.

So, instead of removing it I have guarded it with #ifndef PRODUCT and 
changed to use tty rather than gclog_or_tty. Here's an updated webrev:

http://cr.openjdk.java.net/~brutisso/8143544/webrev.01/

I've also updated the synopsis of the Jira issue to be "Make 
CMSCollector::is_cms_reachable() non-product".

Thanks,
Bengt
>
>
>     If we decide to keep the code I think we should switch from using
>     gclog_or_tty to using tty for printing. If you are in a debugger
>     (gdb or similar) you normally want the output on stdout and not to
>     some file that happened to be on the command line. :)
>
>
> Good point.
>
> - ramki
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20151124/f74d8cb4/attachment.html>


More information about the hotspot-gc-dev mailing list