RFR (M): 8136681: Factor out IHOP calculation from G1CollectorPolicy

Erik Helin erik.helin at oracle.com
Tue Nov 24 10:06:44 UTC 2015


On 2015-11-23, Thomas Schatzl wrote:
> Hi Erik
> 
> On Fri, 2015-11-20 at 17:26 +0100, Erik Helin wrote:
> > On 2015-11-16, Thomas Schatzl wrote:
> > > Hi Jon,
> > > 
> > >   thanks a lot for all these reminders for better documentation. I have
> > > been working too long on this functionality so that "everything is
> > > clear" to me :)
> > > 
> > > New webrevs with hopefully more complete explanations at:
> > > http://cr.openjdk.java.net/~tschatzl/8136681/webrev.1_to_2/
> > > (incremental)
> > > http://cr.openjdk.java.net/~tschatzl/8136681/webrev.2/ (changes)
> > 
> > Hi Thomas,
> > 
> > here comes a small partial review:
> 
>   thanks for looking.
> 
> > 
> > g1IHOPControl.cpp:
> >   109 #endif
> >   110 
> >   111 #ifndef PRODUCT
> > - Please continue using the existing #ifndef
> > 
> >   82   size_t threshold;
> >   83   
> >   84   threshold = ctrl.get_conc_mark_start_threshold();
> > - Please initialize the variable when you declare it
> > 
> > Other:
> > - Maybe rename _last_allocated_old_bytes to
> >   _bytes_allocated_in_old_since_last_gc?
> 
>   all fixed in
> 
> http://cr.openjdk.java.net/~tschatzl/8136681/webrev.3_to_4 
> http://cr.openjdk.java.net/~tschatzl/8136681/webrev.4

Ok, I this is good to go.

Thanks,
Erik

> Thanks,
>   Thomas
> 


More information about the hotspot-gc-dev mailing list