RFR: JDK-8143544: Remove CMSCollector::is_cms_reachable()

Bengt Rutisson bengt.rutisson at oracle.com
Wed Nov 25 07:49:07 UTC 2015


Thanks for reviewing this, Ramki!

Bengt

On 2015-11-24 20:49, Srinivas Ramakrishna wrote:
> Looks good to me too; thanks!
> -- ramki
>
> On Tue, Nov 24, 2015 at 12:46 AM, Bengt Rutisson 
> <bengt.rutisson at oracle.com <mailto:bengt.rutisson at oracle.com>> wrote:
>
>
>
>     On 2015-11-24 09:51, Thomas Schatzl wrote:
>
>         Hi,
>
>         On Tue, 2015-11-24 at 09:03 +0100, Bengt Rutisson wrote:
>
>             Hi Ramki and Thomas,
>
>         [...]
>
>
>             I checked with sustaining. They have not been using this
>             code for
>             quite some time but they would like to keep it.
>
>             So, instead of removing it I have guarded it with #ifndef
>             PRODUCT and
>             changed to use tty rather than gclog_or_tty. Here's an
>             updated webrev:
>
>             http://cr.openjdk.java.net/~brutisso/8143544/webrev.01/
>             <http://cr.openjdk.java.net/%7Ebrutisso/8143544/webrev.01/>
>
>             I've also updated the synopsis of the Jira issue to be "Make
>             CMSCollector::is_cms_reachable() non-product".
>
>
>            looks good.
>
>
>     Thanks, Thomas!
>
>     Bengt
>
>
>
>         Thomas
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20151125/ed37dbe5/attachment.html>


More information about the hotspot-gc-dev mailing list