RFR (M): 8060697: Improve G1 Heap Growth Heuristics

Tom Benson tom.benson at oracle.com
Wed Nov 25 20:01:18 UTC 2015


Hi Kim,
OK, I agree.  Thanks,
Tom

On 11/25/2015 2:38 PM, Kim Barrett wrote:
> On Nov 25, 2015, at 9:06 AM, Tom Benson <tom.benson at oracle.com> wrote:
>> Hi Kim,
>> Thanks very much for the review.  I've implemented all your suggestions.
>>
>> About this:
>>
>>> I suspect you are introducing some implicit conversions that will cause
>>> problems for the SAP folks; see discussion of 8143215:
>> ... I think there's one, which is:
>>
>>     expand_bytes = expand_bytes * scale_factor;
>>
>> scale_factor is explicitly limited to being between 0.2 and 2.0, and expand_bytes is fraction of the heap size, so there's no chance of overflow.  Would you object to the static cast in this case?  How about with a comment?
> A static_cast there would be fine with me.  And that’s the only one I see too.
>



More information about the hotspot-gc-dev mailing list