Request for code review - JDK-8141123 Change int's to size_t in FreeIdSet

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 26 11:13:57 UTC 2015


Hi,

On Wed, 2015-11-25 at 17:34 -0500, Kim Barrett wrote:
> On Nov 12, 2015, at 4:35 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> > 
> > - FreeIdSet::set_safepoint() seems to be never called. I think it
> > allows you to remove a *lot* of unused stuff.
> 
> Perhaps the bug here is that there should be calls to set_safepoint but they are missing?
> 

  apparently the functionality is not needed, that is, it has not even
been in use in the initial integration of G1 (and it has been added in
that change).

So I suggest to just remove it and everything that depended on it
instead of trying to find out what this functionality may have been used
for.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list