RFR: 8144145: G1GCPhaseTimes should allow externally accounted time

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 26 16:11:39 UTC 2015


Hi,

On Thu, 2015-11-26 at 16:31 +0100, Erik Helin wrote:
> Hi all,
> 
> this small patch allows code to report accounted time to
> G1GCPhaseTimes, for example if something takes time that isn't tracked
> by G1GCPhaseTimes (code in the runtime, shared code, etc. that
> might be logged some other way).
> 
> Enhancement:
> https://bugs.openjdk.java.net/browse/JDK-8144145
> 
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8144145/webrev.00/
> 
> Testing:
> - GC Basher with full verification.

  looks okay. Can you change the name of the accessor to that field to
correspond to the field name, i.e. without the "ly" suffix?

I prefer these accessors to correspond exactly to the member variable,
even ignoring proper English sometimes.

I do not need to see a changeset for such a change

Thomas



More information about the hotspot-gc-dev mailing list