RFR (XS) 8153277: [TESTBUG] gc/arguments/TestMaxMinHeapFreeRatioFlags is too sensitive for stray allocations in verifyRatio
dmitry.fazunenko at oracle.com
Fri Apr 1 16:07:10 UTC 2016
Still looks good :)
On 01.04.2016 18:58, Aleksey Shipilev wrote:
> Thanks Dmitry!
> I realized that my hs-rt workspace was older than I thought. Rebased the
> patch, and verified it still fixes the trouble:
> On 04/01/2016 05:56 PM, Dmitry Fazunenko wrote:
>> Hi Aleksey,
>> The change looks good.
>> Pls, fix the copyright before push.
>> On 01.04.2016 16:59, Aleksey Shipilev wrote:
>>> Please review a preemptive fix in TestMaxMinHeapFreeRatioFlags test.
>>> This failure only reproduces when you switch the JEP 280 concat strategy
>>> to something more advanced than it is now.
>>> The test would fail if we silently bring more objects in the heap in the
>>> middle of the test. Notably, this will happen inside of verifyRatio
>>> helper method which does a String concat -- on first invocation it will
>>> lazily initialize j.l.invoke infra. We need to prime the utility methods
>>> before using them within the test.
>>> Testing: offending test; going to run JPRT -testset hotspot during a
More information about the hotspot-gc-dev