RFR(XXS): 8153176: ParOldGC's ParallelTaskTerminator peeks wrong TaskQueueSet

Thomas Schatzl thomas.schatzl at oracle.com
Tue Apr 5 10:21:37 UTC 2016


Hi,

On Fri, 2016-04-01 at 12:53 +0000, Reingruber, Richard wrote:
> Hi Mikael,
> 
>   > > Hi Mikael,
>   > >
>   > >    Mikael> As I mentioned in the bug I think the same problem
> affects parallel
>   > >    Mikael> reference processing as well, see
> RefProcTaskExecutor::execute in
>   > >    Mikael> pcTasks.cpp.
>   > >
>   > > Oh cool you saw this! Should I change this, too?
>   > 
>   > Yes, it's just as incorrect as the one you originally found.
> 
> Ok, I have prepared a second webrev that fixes
> RefProcTaskExecutor::execute(), too.
> 
> http://cr.openjdk.java.net/~simonis/webrevs/2016/8153176_paroldgc_wro
> ng_taskqueueset_in_marking/webrev_02/
> 
> Could you please sponsor the change, when it's reviewed?

looks good. Thanks for catching this :)

Thomas


More information about the hotspot-gc-dev mailing list