RFR: 8152639: ResourceMark missing in reportFreeListStatistics

Stefan Karlsson stefan.karlsson at oracle.com
Fri Apr 8 07:56:22 UTC 2016


Hi Stefan,

Updated webrev with your suggestion:

http://cr.openjdk.java.net/~stefank/8152639/webrev.02.delta
http://cr.openjdk.java.net/~stefank/8152639/webrev.02

Thanks,
StefanK

On 2016-04-08 09:46, Stefan Johansson wrote:
> Hi Stefan,
>
> On 2016-04-05 18:13, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please review this ensure that a ResourceMark is used before the 
>> logging stream is used. The patch uses a LogStream instances, which 
>> embeds the ResourceMark.
>>
>> http://cr.openjdk.java.net/~stefank/8152639/webrev.01
>> https://bugs.openjdk.java.net/browse/JDK-8152639
>>
> Looks good. If you like you could also change the lines below to use 
> LogStream and remove that ResourceMark:
>
>  513   if (log.is_trace()) {
>  514     ResourceMark rm;
>  515     reportIndexedFreeListStatistics(log.trace_stream());
>
> Thanks,
> StefanJ
>> I've manually verified that the output is the same.
>>
>> Thanks,
>> StefanK
>



More information about the hotspot-gc-dev mailing list