RFR (M): 8153503: Move remset scan iteration claim to remset local data structure

Thomas Schatzl thomas.schatzl at oracle.com
Thu Apr 14 13:55:08 UTC 2016


Hi Mikael,

On Thu, 2016-04-14 at 15:11 +0200, Mikael Gerdin wrote:
> Hi Thomas,
> 
> On 2016-04-14 11:56, Thomas Schatzl wrote:
> > Hi,
[...]
> >    new webrevs at
> > http://cr.openjdk.java.net/~tschatzl/8153503/webrev.0_to_1/ (diff)
> > http://cr.openjdk.java.net/~tschatzl/8153503/webrev.1/ (full)
> 
> This looks fine to me.
> 
> The indentation is a bit fishy in g1RemSet.cpp
>   272   if (_scan_state->set_iter_complete(region_idx)) {
>   273      // Scan the strong code root list attached to the current
> region
>   274      scan_strong_code_roots(r);
> 
> I don't need to see a new webrev for that, though :)
> 

  fixed :) Thanks for your review.

Thomas


More information about the hotspot-gc-dev mailing list