Fwd: Re: RFR: 8133051: Concurrent refinement threads may be activated and deactivated at random
derek.white at oracle.com
Fri Apr 15 19:03:28 UTC 2016
[Resend to correct email list]
-------- Forwarded Message --------
Subject: Re: RFR: 8133051: Concurrent refinement threads may be
activated and deactivated at random
Date: Fri, 15 Apr 2016 13:12:28 -0400
From: Derek White <derek.white at oracle.com>
On 4/12/16 2:31 PM, Kim Barrett wrote:
>> On Apr 4, 2016, at 2:48 PM, Kim Barrett<kim.barrett at oracle.com> wrote:
>> Please review this change to the G1 concurrent refinement thread
>> controller. This change addresses unnecessary activation when there
>> are many threads and few buffers to be processed. It also addresses
>> delayed activation due to mis-configuration of the dirty card queue
>> set's notification mechanism.
> I had been hoping I might come back from vacation and find some reviews waiting for me to look at.
My final comment:
- In ConcurrentG1Refine::create(), around line 188, it would be nice to
log number "max number of concurrent refinement threads" (aka
thread_num() aka _n_worker_threads).
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev