RFR(S) 8154752: Cleanup initialization of G1Policy

Mikael Gerdin mikael.gerdin at oracle.com
Thu Apr 21 09:04:13 UTC 2016


Hi,

On 2016-04-21 10:57, Thomas Schatzl wrote:
> Hi,
>
> On Thu, 2016-04-21 at 09:53 +0200, Mikael Gerdin wrote:
>> Hi all,
>>
>> Please review this small cleanup partially suggested in the review of
>> 8154154.
>> The change modifies G1Policy to initialize its members in the
>> initialization list instead of in the constructor body and clarifies
>> the
>> dependencies that the G1Policy::init method has on G1CollectedHeap by
>> forcing a caller to pass a heap and collection set pointer.
>> The reasoning behind forcing the caller to pass a G1CollectionSet* is
>> that I want to move towards only exposing "const G1CollectionSet*" in
>> G1CollectedHeap. G1Policy is one of the places where it's clearly
>> necessary to have a mutable G1CollectionSet.
>>
>> Testing: RBT GC Testing
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154752
>> Webrev: http://cr.openjdk.java.net/~mgerdin/8154752/webrev.0

Thanks for the reviews.
Since this is a fairly simple cleanup I'd like to push this without 
waiting 24 hours for further reviews, any objections at this point?

/Mikael

>
>    looks good.
>
> Thomas
>


More information about the hotspot-gc-dev mailing list