RFR: 8154759: [TESTBUG] GC tests should be changed to be able to execute with -Xlog:all=trace.

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Thu Apr 21 09:47:14 UTC 2016


Jon,

On 21.04.2016 1:13, Jon Masamitsu wrote:
>
>
> On 04/20/2016 09:53 AM, Michail Chernov wrote:
>> HI Jon,
>>
>> This is the way to remove new unified logging options, like 
>> -Xlog:all=trace or -Xlog:gc*=trace. Tests define -Xlog:... inside for 
>> checking,
> Sorry, but I still don't understand.  "Tests define -Xlog:..." means 
> that the tests
> have built into them unified logging style flags?

Michail used not proper wording "will conflict". The flags of the tests 
and possible external -Xlog flags will not conflict, but the test might 
fail, if external options turn more logging on.
The fix protects the test from extra logging.

Michail, the fix looks good to me.

Thanks,
Dima



>
> Jon
>
>> new GC baseline will conflict with these tests, so filtering of 
>> -Xlog* will allow us to run these tests in that new nightly testing.
>>
>> Michail
>>
>> On 20.04.2016 19:22, Jon Masamitsu wrote:
>>> Michail,
>>>
>>> Is this the common way of dealing with obsolete command line flags?  To
>>> filter them out instead of removing the obsolete flags?
>>>
>>> Jon
>>>
>>> On 04/20/2016 09:03 AM, Michail Chernov wrote:
>>>> Hi,
>>>>
>>>> Could I have a reviews for this small change please.
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8154759
>>>> http://cr.openjdk.java.net/~mchernov/8154759/webrev.00/
>>>>
>>>> Tests now filter out -Xlog* option. This is needed because we are 
>>>> going to extend GC nightly by adding -Xlog:all=trace to default GC 
>>>> baseline to check unified gc logging 
>>>> (https://bugs.openjdk.java.net/browse/JDK-8150845).
>>>>
>>>> Thanks
>>>> Michail
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160421/c0de12da/attachment.html>


More information about the hotspot-gc-dev mailing list