RFR: 8154759: [TESTBUG] GC tests should be changed to be able to execute with -Xlog:all=trace.
jon.masamitsu at oracle.com
Thu Apr 21 21:07:19 UTC 2016
On 04/21/2016 10:13 AM, Michail Chernov wrote:
>>>> HI Jon,
>>>> This is the way to remove new unified logging options, like
>>>> -Xlog:all=trace or -Xlog:gc*=trace. Tests define -Xlog:... inside
>>>> for checking,
>>> Sorry, but I still don't understand. "Tests define -Xlog:..." means
>>> that the tests
>>> have built into them unified logging style flags?
>> Michail used not proper wording "will conflict". The flags of the
>> tests and possible external -Xlog flags will not conflict, but the
>> test might fail, if external options turn more logging on.
>> The fix protects the test from extra logging.
>> Michail, the fix looks good to me.
> Dima, thanks for your review. Your explanation describes reason of
> this change correctly. External -Xlog* flags can make logging level
> more detailed than tests wait for.
Thanks for the explanation. Changes look good.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev