RFR (S): 8155232: Augment Workgang to run task with a given number of threads

Jon Masamitsu jon.masamitsu at oracle.com
Thu Apr 28 17:15:38 UTC 2016


Looks good.

Jon

On 04/28/2016 05:14 AM, Thomas Schatzl wrote:
> Hi Stefan,
>
> On Thu, 2016-04-28 at 13:58 +0200, Stefan Karlsson wrote:
>> Hi Thomas,
>>
>> This change looks fine.
>>
>> I have a slight reservation about using the word "thread" in this
>> context, since the tasks might be executed on a lower number of
>> threads.
>> The surrounding code uses the word "workers" instead of "threads".
>> Maybe
>> your function code be named run_task_on_workers, or maybe even use
>> an
>> overloaded run_task function?
>    made an overloaded run_task(). Sorry.
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8155232/webrev.1/
>
> Also fixed up all dependent changesets in place due to the triviality
> of this name change.
>
> Thanks,
>    Thomas
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160428/d16cbcda/attachment.html>


More information about the hotspot-gc-dev mailing list