RFR (M): 8153507: Improve Card Table Clear Task

Thomas Schatzl thomas.schatzl at oracle.com
Fri Apr 29 07:08:39 UTC 2016


Hi Jon,

On Thu, 2016-04-28 at 13:18 -0700, Jon Masamitsu wrote:
> http://cr.openjdk.java.net/~tschatzl/8153507/webrev/src/share/vm/gc/g
> 1/g1RemSet.cpp.frames.html
> 
> 
> IsDirtyRegionState will probably always be a jbyte 
>   161     memset(_in_dirty_region_buffer, Clean, _max_regions *
> sizeof(jbyte));
> 
> 
> but maybe this would be appropriate
> 
>  161     memset(_in_dirty_region_buffer, Clean, _max_regions *
> sizeof(IsDirtyRegionState));
> 
> _cur_dirty_regions is the index of a single region, yes?  So the
> singular form _cur_dirty_region is more accurate?
> 
> Rest looks good.
> 
> My two  points are minor so I don't need to see a new webrev (and
> by inference, you can decide which way to go on both).

  I will fix these before pushing.

Thanks for your review,
  Thomas



More information about the hotspot-gc-dev mailing list