RFR: 8148755: -XX:+HeapDumpAfterFullGC creates heap dump both before and after Full GC

sangheon sangheon.kim at oracle.com
Tue Feb 2 23:05:49 UTC 2016


Hi Claes,

Looks good and I have minor comments.

1. Line 598: 'before' should be 'after'.

  597 void CollectedHeap::post_full_gc_dump(GCTimer* timer) {
  598 full_gc_dump(timer, false /* before */);
  599 }


2. Copyright year update.

Thanks,
Sangheon


On 02/02/2016 07:02 AM, Claes Redestad wrote:
> Hello,
>
> this patch fixes an issue where heap is dumped both before and after 
> full GC if either one of -XX:+HeapDumpAfterFullGC or 
> -XX:+HeapDumpBeforeFullGC is specified.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8148755
> Webrev: http://cr.openjdk.java.net/~redestad/8148755/webrev.01
>
> Testing: JPRT, manual verification
>
> Thanks!
>
> /Claes



More information about the hotspot-gc-dev mailing list