RFR: JDK-8148951: Remove unused method Generation::performs_in_place_marking()

David Lindholm david.lindholm at oracle.com
Wed Feb 3 13:24:29 UTC 2016


Bengt,

Your change looks good. Reviewed.

Thanks,
David

On 2016-02-03 13:47, Bengt Rutisson wrote:
>
> Hi everyone,
>
> Could I have a couple of reviews for this small cleanup?
>
> http://cr.openjdk.java.net/~brutisso/8148951/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8148951
>
> The methods Generation::performs_in_place_marking() is documented as 
> that it should be used by biased locking. But it is currently unused 
> and a "hg grep performs_in_place_marking" does not indicate that it 
> was ever used.
>
> Currently it is only used in two asserts, but these operate on a young 
> or an old generation instance, where performs_in_place_marking() adds 
> no value since it returns true for old generations and false for young.
>
> Thanks,
> Bengt



More information about the hotspot-gc-dev mailing list