RFR (s): 8147003: Move BubbleUpRef test into CMS directory
bengt.rutisson at oracle.com
Wed Feb 3 14:02:53 UTC 2016
On 2016-02-03 14:24, Dmitry Fazunenko wrote:
> Hi all,
> May I have a couple of reviews of a simple change:
> This test is not new, I just took the source of existing closed test,
> performed some cosmetic changes and put in open.
> The original logic has preserved unchanged.
I'm fine with pushing this, but I would have preferred if the test would
just have been moved and the cosmetic changes would have been done as a
separate change. Not all of the cosmetic changes are obvious
improvements. I am for example not sure why you wanted to remove the
help text that was logged if the test was started with the wrong arguments.
As I said, unless anybody else thinks otherwise I am ok with this
change. But I would prefer if future changes like this was separated in
to a move that is as clean as possible and then a separate change to
clean the code up.
More information about the hotspot-gc-dev