RFR: 8148973: Rename g1/concurrentMark.{hpp,cpp,inline.hpp} to g1/g1ConcurrentMark.{hpp,cpp,inline.hpp}

Mikael Gerdin mikael.gerdin at oracle.com
Fri Feb 5 13:43:06 UTC 2016


Hi Erik,

On 2016-02-04 10:53, Erik Helin wrote:
> On 2016-02-04, Thomas Schatzl wrote:
>> Hi Erik,
>>
>> On Thu, 2016-02-04 at 09:36 +0100, Erik Helin wrote:
>>> Hi all,
>>>
>>> this patch renames the files g1/concurrentMark.{hpp,cpp,inline.hpp}
>>> to
>>> g1/g1ConcurrentMark.{hpp,cpp,inline.hpp} (the prefix g1 is added).
>>> The
>>> classes in files have also been prefixed with G1 where it makes sense
>>> (e.g. ConcurrentMark is now G1ConcurrentMark).
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8148973/00/
>>>
>>> Testing:
>>> - JPRT
>>> - Using grep to verify that the names of the old classes are no
>>> longer
>>>    used (not even in comments).
>>
>>    some initial comments:
>>
>> - the defines in the hpp files need to be fixed too.
>>
>> - copyright updates for concurrentMarkThread*, g1CollectedHeap.*hpp,
>> g1CollectorPolicy, g1EvacFailure*, whitebox.cpp
>
> Thanks for reviewing! Incremental patch at:
>
> http://cr.openjdk.java.net/~ehelin/8148973/00-01/

Seems ok to me.
/Mikael


>
> Thanks,
> Erik
>
>> Thanks,
>>    Thomas



More information about the hotspot-gc-dev mailing list