RFR: 8148745: [testbug] Test gc/g1/plab/TestPLABPromotion.java fails in nightly

Thomas Schatzl thomas.schatzl at oracle.com
Mon Feb 8 13:23:10 UTC 2016


Hi,

On Fri, 2016-02-05 at 18:09 +0300, Michail Chernov wrote:
> Hi all,
> 
> Could I have a couple of review for this change:
> 
> Webrev: http://cr.openjdk.java.net/~mchernov/8148745/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8148745
> 
> Added -XX:MaxTenuringThreshold=1 to achieve objects promotion at
> every GC.
> Added timeout for TestPLABPromotion.java because it can work 
> sufficient time with -Xcomp.

Since -Xcomp does not seem to add any new information to the test,
couldn't it simply be disallowed to use with this test instead?

> Added @requires to exclude test execution with Flight Recorder, 
> because test cannot handle case when some additional objects are 
> created before or during test running.
> Checking of size of promoted objects was changed because difference 
> of real allocated objects and promoted can exceed existing limit with
> big heap size.

The 01 version looks okay. I assume proper testing with this change has
been performed (running it through our test systems a few times).

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list