RFR (XXS): 8149364: Quarantine TestSelectDefaultGC.java test

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Mon Feb 8 15:04:16 UTC 2016


Jesper,

Thank you for reviewing the fix.

Here are a new webrev:
http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8149364/webrev.01/

Regards, Kirill

On 08.02.2016 17:43, Jesper Wilhelmsson wrote:
> Hi,
>
> To make it clear from the error message that the test is ignored when
> running the test, it is a good convention to always place the @ignore
> right before the first @run. The way it is placed now (before a @library
> tag) the error message will not say that the test is ignored.
>
> The way the tag is placed now it will be reported as:
>
> test result: Error. Parse Exception: `@library' must appear before first
> `@run'
>
> If you move it down to be before the @run it will say:
>
> result: Error. Test ignored: 8148239
>
> Thanks,
> /Jesper
>
>
> Den 8/2/16 kl. 15:03, skrev Kirill Zhaldybin:
>> Dear all,
>>
>> Could you please review this small fix for JDK-8149364?
>> Since the fix of JDK-8148239 is blocked I added @ignore tag to
>> TestSelectDefaultGC.java to quarantine it.
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8149364
>>
>> WebRev:
>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8149364/webrev.00/
>>
>> Thank you.
>>
>> Regards, Kirill



More information about the hotspot-gc-dev mailing list