RFR: 8146989: Introduce per-worker preserved mark stacks in ParNew

Thomas Schatzl thomas.schatzl at oracle.com
Mon Feb 8 15:56:48 UTC 2016


Hi,

On Mon, 2016-02-08 at 09:49 -0500, Tony Printezis wrote:
> Thanks Thomas. Also, if you could do a JPRT run I’d very much
> appreciate it.

that is of course part of it.

It found two issues:
 - RemoveForwardedPointerClosure::do_object() needs to be moved to the
preservedMarks.inline.hpp as it uses oopDesc::is_forwarded() and
init(). Then also oop.inline.hpp needs to be included there.

 - PreservedMarksSet::reclaim() needs to call
~Padded<Preservedmarks>(), not just ~PreservedMarks. 

> 
> FWIW, I tested it with doing many runs of all the usual test suites
> with -XX:+PromotionFailureALot -XX:PromotionFailureALotCount=150 
> -XX:PromotionFailureALotInterval=2 and this cause a bunch of
> promotion failures. I didn’t see any issues.
> 
> I also have the ParallelScavenge changes done (using the abstractions
> introduced here). I’ll open those for code review when this is done.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list