RFR: 8149648: Add number of regions to the G1HeapSummary event

Stefan Johansson stefan.johansson at oracle.com
Thu Feb 11 12:41:39 UTC 2016


Hi David,

On 2016-02-11 12:53, David Lindholm wrote:
> Hi,
>
> Please review this patch that adds information about the number of 
> regions to the G1HeapSummary event.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8149648
> Webrev: http://cr.openjdk.java.net/~david/JDK-8149648/webrev.00/
>
Looks good in general, but I would prefer a more descriptive name than 
_regions in G1HeapSummary, something like _numberOfRegions and then 
maybe have that propagated into the trace.xml as well. The label already 
have this info, but I would be nice if it was reflected in the code as well.

Thanks,
Stefan
>
> Thanks,
> David



More information about the hotspot-gc-dev mailing list