RFR: 8149650: Create a trace event for G1 heap region type transitions

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Thu Feb 11 17:51:01 UTC 2016


Looks good!
/Jesper

Den 11/2/16 kl. 17:16, skrev David Lindholm:
> Hi Jesper,
>
> Thanks for looking at this!
>
> On 2016-02-11 14:35, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> heapRegion.hpp, set_*() - I don't really like that we have code in .hpp files.
>> Since these functions now do more than just set stuff I would prefer if they
>> moved into the .cpp file.
>
> Absolutely. New webrev:
>
> http://cr.openjdk.java.net/~david/JDK-8149650/webrev.01/
>
>
> Thanks,
> David
>
>> /Jesper
>>
>> Den 11/2/16 kl. 13:14, skrev David Lindholm:
>>> Hi,
>>>
>>> Please review this patch that adds a trace event that the vm sends each time a
>>> G1 Heap Region changes type.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8149650
>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8149650/webrev.00/
>>>
>>>
>>> Thanks,
>>> David
>


More information about the hotspot-gc-dev mailing list