RFR: 8149793: DirtyCardQueueSet::apply_closure_to_completed_buffer_helper isn't helpful

Thomas Schatzl thomas.schatzl at oracle.com
Tue Feb 16 09:07:57 UTC 2016


Hi Kim,

  some minor comments about the change:

On Mo, 2016-02-15 at 02:24 -0500, Kim Barrett wrote:
> Please review this small cleanup, merging a non-helpful "helper" into
> its only caller.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8149793
> 
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8149793/webrev.00/
> 

  - could the assert be enhanced to print the values of the checked
variables to see what actually failed?

  - I would prefer if in the if-clause, the seemingly more common case
of the buffer should be put first, i.e.

BufferNode* nd = ...;
if (nd != NULL) {
  // work on buffer
} else {
  return false;
}

like it has been in the original code.

Feel free to ignore that last case though.

Also, see Bengt's comments.

Thanks,
  Thomas

Thanks,
  Thomas



More information about the hotspot-gc-dev mailing list