RFR: 8149793: DirtyCardQueueSet::apply_closure_to_completed_buffer_helper isn't helpful
kim.barrett at oracle.com
Wed Feb 17 20:12:06 UTC 2016
> On Feb 15, 2016, at 2:30 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
> On 2016-02-15 08:24, Kim Barrett wrote:
>> Please review this small cleanup, merging a non-helpful "helper" into
>> its only caller.
> Looks good.
> Good cleanup as it is. If you want to take it further I would personally prefer to remove the default values for the parameters:
> 135 bool apply_closure_to_completed_buffer(CardTableEntryClosure* cl,
> 136 uint worker_i = 0,
> 137 int stop_at = 0,
> 138 bool during_pause = false);
> Both callers of apply_closure_to_completed_buffer() pass values for worker_ and stop_at. And the "during_pause" is used to assert the state of the call, so it is a bit odd that callers don't have to explicitly pass this state.
Good suggestion. Will do.
Thanks for reviewing.
More information about the hotspot-gc-dev