RFR (S) JDK-8139651 JDK-8139651, ConcurrentG1Refine uses ints for many of its members that should be unsigned types

Kim Barrett kim.barrett at oracle.com
Fri Feb 19 20:05:39 UTC 2016


> On Feb 19, 2016, at 1:38 PM, Joseph Provino <joseph.provino at oracle.com> wrote:
> 
> 
> 
> On 2/19/2016 12:44 PM, Kim Barrett wrote:
>>> On Feb 19, 2016, at 12:04 PM, Joseph Provino <joseph.provino at oracle.com> wrote:
>>> 
>>> New webrev is here: http://cr.openjdk.java.net/~jprovino/8139651/webrev.02
>> It looks like this incorrect change is still in place:
>> src/share/vm/gc/g1/ptrQueue.hpp
>> 220   size_t _process_completed_threshold;
>> 242   size_t _max_completed_queue;
>> 
> Hi Kim, I thought you said you have a fix for it in progress.
> Should I just change them back to int’s?

I have a fix for the current messy state in progress.  That doesn’t mean we can
go ahead with a change that puts us into an intermediate state that isn’t right.
(Even if my supposition is correct, that the intermediate state might still work by
accident.)  So please don’t change these to unsigned.

> 
> src/share/vm/gc/g1/ptrQueue.hpp
> 220   size_t _process_completed_threshold;
> 242   size_t _max_completed_queue;



More information about the hotspot-gc-dev mailing list