RFR (S): 8076463: Add logging for the preserve CM referents task

Jon Masamitsu jon.masamitsu at oracle.com
Thu Feb 25 15:56:39 UTC 2016


Thomas,

Why did you decide to move preserve_cm_referents() out of
process_discovered_references()?  The work done in
preserve_cm_referents() has to be performed before it
is safe to do the work in process_discovered_references()
so it seems safer to call preserver_cm_referents() at
the beginning of preserve_discovered_references().

Jon


On 2/25/2016 5:35 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for the following change that adds logging for the
> Preserve CM referents task that has previously been summarized under
> the "Other" category?
>
> It sometimes seems that this part of the GC takes a long time, so these
> measurements at least increase awareness of any problem.
>
> I also took the opportunity to move that code related to that phase
> into a new method. This will slightly ease any further work in this
> area.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8076463
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8076463/webrev/
> Testing:
> jprt, unit test
>
> Thanks,
>    Thomas



More information about the hotspot-gc-dev mailing list