RFR (XS): 8140777: Make Adaptive IHOP logging information the same as JFR logging

Thomas Schatzl thomas.schatzl at oracle.com
Thu Feb 25 16:01:15 UTC 2016


Hi Jon,

On Tue, 2016-02-23 at 11:06 -0800, Jon Masamitsu wrote:
> 
> On 2/23/2016 3:58 AM, Thomas Schatzl wrote:
> > Hi Jon,
> > 
> >    sorry for the long delay, just found this in my inbox:
> > 
> > On Tue, 2016-02-09 at 10:28 -0800, Jon Masamitsu wrote:
> > > Thomas,
> > > 
> > > For _last_unrestrained_young_size the title is "additional buffer
> > > size".
> > > 
> > > Is there anything more descriptive that occurs to you?  Even
> > > (if correct) "current eden size" might be more helpful.  Let the
> > > reader make the connection between eden size and  "additional
> > > buffer".   I'm making this up as I go so if it doesn't make
> > > sense,
> > > do spend time on trying to make sense of it.
> >    I am kind of torn on this issue: while the additional buffer is
> > current eden size at this time, it may not be the only source of an
> > additional safety buffer, or it might just be something calculated
> > based on it in the future.
> > 
> > So I would prefer to keep the fact that the additional buffer is
> > exactly the current eden size at this time implementation internal.
> 
> Not having a good suggestion for a better name, leaving it is fine
> with
> me.

  thanks for the review.

Thomas



More information about the hotspot-gc-dev mailing list