RFR (S) JDK-8139651 JDK-8139651, ConcurrentG1Refine uses ints for many of its members that should be unsigned types

Thomas Schatzl thomas.schatzl at oracle.com
Fri Feb 26 10:31:36 UTC 2016


Hi,

On Thu, 2016-02-25 at 14:11 -0500, Joseph Provino wrote:
> 
> Latest is here: 
> http://cr.openjdk.java.net/~jprovino/8139651/webrev.05

  looks good. Some remaining minor issues:

- concurrentG1RefineThread.cpp:71: indentation

- the selected thresholds for the flags will cause overflows in the
calculations later, look for uses of
G1ConcRefinementServiceIntervalMillis, the *Zone values (e.g. in
g1CollectedHeap.cpp:1988f, g1CollectorPolicy.cpp:1323f,... I recommend
keeping max_intx at most.

Sorry for earlier comments to the opposite :(

I think this can be done without a re-review from my pov (unless more
issues pop up).

Thanks,
  Thomas


More information about the hotspot-gc-dev mailing list