RFR: 8145908: [Newtest] Multi-threading stress test for G1 Remembered Sets

Michail Chernov michail.chernov at oracle.com
Mon Feb 29 15:24:56 UTC 2016


Hi Dima,

Test looks good to me.

Some minor issues:
1. " * @library /testlibrary " - /testlibrary is not necessary, test 
does not depend on any test library classes.
2. " * @modules java.base/sun.misc" - is not necessary too.

No extra webrev is required.

Thanks
Michail


On 24.02.2016 21:47, Dmitry Fazunenko wrote:
> Hi Thomas,
>
> The new version where all your comments addressed:
>    http://cr.openjdk.java.net/~dfazunen/8145908/webrev.03/
>
> To clarify the idea of usage a window within STORAGE I added the 
> following comment:
>
>     // To cause Remembered Sets change their coarse level the test 
> uses a window
>     // within STORAGE. All the BUFFER elements refer to only STORAGE 
> objects
>     // from the current window. The window is defined by a range.
>     // The first element has got the index: 'windowStart',
>     // the last one: 'windowStart + windowSize - 1'
>     // The window is shifting periodically.
>
> Thanks,
> Dima
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160229/e25f76a9/attachment.html>


More information about the hotspot-gc-dev mailing list