RFR: 8145908: [Newtest] Multi-threading stress test for G1 Remembered Sets

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Mon Feb 29 15:27:09 UTC 2016


Hi Misha!

Thanks for the comments! I'll fix as you suggested and test before push.

-- Dima

On 29.02.2016 18:24, Michail Chernov wrote:
> Hi Dima,
>
> Test looks good to me.
>
> Some minor issues:
> 1. " * @library /testlibrary " - /testlibrary is not necessary, test 
> does not depend on any test library classes.
> 2. " * @modules java.base/sun.misc" - is not necessary too.
>
> No extra webrev is required.
>
> Thanks
> Michail
>
>
> On 24.02.2016 21:47, Dmitry Fazunenko wrote:
>> Hi Thomas,
>>
>> The new version where all your comments addressed:
>> http://cr.openjdk.java.net/~dfazunen/8145908/webrev.03/
>>
>> To clarify the idea of usage a window within STORAGE I added the 
>> following comment:
>>
>>     // To cause Remembered Sets change their coarse level the test 
>> uses a window
>>     // within STORAGE. All the BUFFER elements refer to only STORAGE 
>> objects
>>     // from the current window. The window is defined by a range.
>>     // The first element has got the index: 'windowStart',
>>     // the last one: 'windowStart + windowSize - 1'
>>     // The window is shifting periodically.
>>
>> Thanks,
>> Dima
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160229/b2a1647f/attachment.html>


More information about the hotspot-gc-dev mailing list