RFR: 8160827: gc/stress/TestStressG1Humongous.java fails with OOME

Michail Chernov michail.chernov at oracle.com
Tue Jul 19 14:46:02 UTC 2016


Thank you!

Will add your suggestions into code before pushing.

Michail

On 19.07.2016 17:43, Thomas Schatzl wrote:
> Hi,
>
> On Tue, 2016-07-19 at 17:31 +0300, Michail Chernov wrote:
>> Hi Thomas,
>>
>> Thanks a lot for reviewing this.
>>
>> I updated the change, could you take another look at this, please.
>> Test
>> was excluded on 32-bit systems couple of day ago. I removed this
>> @requires. Also added simple checking in
>> getExpectedAmountOfObjects().
>>
>> http://cr.openjdk.java.net/~mchernov/8160827/webrev.01/
>>
>> Checked locally with 32-bit JVM - test passed.
>    okay, looks good.
>
> Please change "there is no available memory" to "selected maximum heap
> is not large enough to contain more than two regions".
>
> Maybe one could make the "2" a local final constant and use that in the
> log message too.
>
> I do not need to re-review such a change.
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list