Request for Review(xs) - 8155263: DisableStartThread should not be applied to GC worker threads

sangheon sangheon.kim at oracle.com
Tue Jul 19 18:11:50 UTC 2016


Hi Jon,

The change looks good to me too.

Thanks,
Sangheon


On 07/19/2016 10:47 AM, Jon Masamitsu wrote:
> Thanks, Thomas, for the Review.
>
> I still need one more review, please.
>
> Jon
>
> On 7/12/2016 11:49 AM, Jon Masamitsu wrote:
>> Yes, Thomas, you guessed correctly.  And so others don't have to guess.
>>
>> http://cr.openjdk.java.net/~jmasa/8155263/webrev.00/
>>
>> Thanks.
>>
>> Jon
>>
>> On 7/12/2016 10:37 AM, Jon Masamitsu wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8155263
>>>
>>> The flag DisableStartThread is defined for Java threads
>>>
>>>   develop(bool, DisableStartThread, false, \
>>>           "Disable starting of additional Java threads " \
>>>           "(for debugging only)")
>>>
>>> but was being applied to GC threads in one case.  I removed
>>> that use.
>>>
>>> Tested by comparing the GC threads before and after the
>>> change to verify that the concurrent GC threads were running.
>>>
>>> Using +DisableStartThread on the command line cause the Java
>>> threads not to run and under those circumstances a safepoint
>>> is not reached (Java threads never get there).  Any of the test
>>> programs I tried hung at the first GC.
>>>
>>> Thanks.
>>>
>>> Jon
>>>
>>
>



More information about the hotspot-gc-dev mailing list