Request for Review (xs) - 8159073: Error handling incomplete when creating GC threads lazily

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jul 21 08:20:42 UTC 2016


Hi Jon,

On Wed, 2016-07-20 at 20:43 -0700, Jon Masamitsu wrote:
> It's ready again.
> 
> Delta: http://cr.openjdk.java.net/~jmasa/8159073/webrev_delta_01_02/
> Full: http://cr.openjdk.java.net/~jmasa/8159073/webrev.02/
> 

  this looks good, except for the two log messages. They seem to be
superfluous because first the callers of run_task(, uint) already print
mostly the same message, and the given code guarantee's that whatever
is printed anyway. Further, a single invocation of run_task will now
trigger three messages basically telling the same.

So I would prefer if these messages were either moved to trace level,
or just removed.

Thanks a lot for your patience with me, :)
  Thomas



More information about the hotspot-gc-dev mailing list