RFR (XS) 8071770 G1 does not implement millis_since_last_gc which is needed by RMI GC

Joseph Provino joseph.provino at oracle.com
Fri Jul 22 14:11:06 UTC 2016


How does this look?

http://cr.openjdk.java.net/~jprovino/8071770/webrev.01

thanks.

joe

On 7/19/2016 10:19 AM, Thomas Schatzl wrote:
> Hi Joe,
>
> On Tue, 2016-07-19 at 10:12 -0400, Joseph Provino wrote:
>> Hi Thomas, I'm not sure what you mean by fix the comment in
>> GenCollectedHeap.
>>
>> Do you mean change the logging message?
>>
>>     if (retVal < 0) {
>>       NOT_PRODUCT(log_warning(gc)("time warp: " JLONG_FORMAT,
>> retVal);)
>>       return 0;
>>     }
>>
>>     if (ret_val < 0) {
>>       log_warning(gc)("millis_since_last_gc() would return : "
>> JLONG_FORMAT
>>         ". returning zero instead.", ret_val);
>>       return 0;
>>     }
>>
> GenCollectedHeap::millis_since_last_gc() talks about
> os::javaTimeMillis() that is not actually used in the first two lines.
> And the third comment provides the same information plus a solution.
>
> I think just removing the first two lines and replacing it by the third
> comment block would be fine.
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list