RFR (XS) 8071770 G1 does not implement millis_since_last_gc which is needed by RMI GC

Joseph Provino joseph.provino at oracle.com
Mon Jul 25 14:49:57 UTC 2016


Can I remove the space after the word "be"?

Do you want to see another webrev?

thanks.

joe

     log_warning(gc)("Detected clock going backwards. "
       "Milliseconds since last GC would be " JLONG_FORMAT
       ". returning zero instead.", ret_val);

     log_warning(gc)("Detected clock going backwards. "
       "Milliseconds since last GC would be " JLONG_FORMAT
       ". returning zero instead.", retVal);


On 7/25/2016 4:21 AM, Thomas Schatzl wrote:
> Hi,
>
> On Fri, 2016-07-22 at 10:11 -0400, Joseph Provino wrote:
>> How does this look?
>>
>> http://cr.openjdk.java.net/~jprovino/8071770/webrev.01
>>
>> thanks.
> I would kind of prefer a something more user-friendly warning message
> (like "Detected clock going backwards. Milliseconds since last GC would
> be " JLONG_FORMAT". Returning zero instead.")
>
> But this is kind of fine with me too.
>
> Ship it.
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list