RFR (XS): 8161993: G1 crashes if active_processor_count changes during startup

Mikael Gerdin mikael.gerdin at oracle.com
Tue Jul 26 08:48:49 UTC 2016


Hi Thomas,

On 2016-07-25 10:14, Thomas Schatzl wrote:
> Hi David,
>
> On Mon, 2016-07-25 at 15:06 +1000, David Holmes wrote:
>> On 22/07/2016 9:35 PM, Thomas Schatzl wrote:
>>>
>>> Hi David,
>>>
> [...]
>>>>>> Also if we log the initial_active_count we should log the
>>>>>> _processor_count too.
>>>>> I can log both in log messages and the error log - although
>>>>> processor
>>>>> count information is already in the log.
>>>> With the new proposal I would just add the logging to
>>>> set_initial_active_processor_count().
>>> New webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8161993/webrev.1/ (full, it's
>>> 5
>>> lines now, so I did not bother creating a diff webrev)
>> Looks good!

Looks good to me as well.

/Mikael

>
>   thanks for the review.
>
> Thanks,
>   Thomas
>


More information about the hotspot-gc-dev mailing list