RFR (XS): 8161993: G1 crashes if active_processor_count changes during startup

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jul 26 08:59:27 UTC 2016


Hi Mikael,

On Tue, 2016-07-26 at 10:48 +0200, Mikael Gerdin wrote:
> Hi Thomas,
> 
> > > > > > > [...]
> > > > > > > Also if we log the initial_active_count we should log the
> > > > > > > _processor_count too.
> > > > > > I can log both in log messages and the error log - although
> > > > > > processor
> > > > > > count information is already in the log.
> > > > > With the new proposal I would just add the logging to
> > > > > set_initial_active_processor_count().
> > > > New webrev:
> > > > http://cr.openjdk.java.net/~tschatzl/8161993/webrev.1/ (full,
> > > > it's
> > > > 5
> > > > lines now, so I did not bother creating a diff webrev)
> > > Looks good!
> Looks good to me as well.

  thanks for your review.

Thomas



More information about the hotspot-gc-dev mailing list