Request for Review (xs) - 8159073: Error handling incomplete when creating GC threads lazily

sangheon sangheon.kim at oracle.com
Fri Jul 29 07:42:41 UTC 2016


Hi Jon,

Looking at the ver.03+delta_03_04, I have a question.
src/share/vm/gc/parallel/psScavenge.cpp.frames.html
line 398, previously we checked active_workers but you are suggesting to 
check total workers.
Is there any reason on this? Looking at the new comment, just adding the 
comment without code change seems correct.

Please update the copyright in TestGCOld.java before pushing this if you 
care.

Thanks,
Sangheon


On 07/28/2016 02:54 PM, Jon Masamitsu wrote:
> I still need one more.
>
> http://cr.openjdk.java.net/~jmasa/8159073/webrev_delta_03_04/
>
> Thanks.
>
> Jon
>
> On 07/26/2016 08:36 AM, Jon Masamitsu wrote:
>> Thomas,
>>
>> Thanks.
>>
>> Jon
>>
>> On 7/26/2016 1:36 AM, Thomas Schatzl wrote:
>>> Hi Jon,
>>>
>>> On Mon, 2016-07-25 at 15:43 -0700, Jon Masamitsu wrote:
>>>>
>>>> On 07/21/2016 06:57 AM, Thomas Schatzl wrote:
>>>>> Hi Jon,
>>>>>
>>>>>
>>> [...]
>>>>>> Delta: http://cr.openjdk.java.net/~jmasa/8159073/webrev_delta_02_
>>>>>> 03/
>>>>>> Full: http://cr.openjdk.java.net/~jmasa/8159073/webrev.03/
>>>>>>
>>>>>> Thanks.
>>>>>    looks good, ship it :)
>>>>   When I ran tests which injected  thread creation failure, this
>>>> guarantee failed.
>>>>
>>>> diff --git a/src/share/vm/gc/shared/workgroup.cpp
>>>> b/src/share/vm/gc/shared/workgroup.cpp
>>>> --- a/src/share/vm/gc/shared/workgroup.cpp
>>>> +++ b/src/share/vm/gc/shared/workgroup.cpp
>>>> @@ -276,7 +276,6 @@
>>>>     guarantee(num_workers > 0, "Trying to execute task %s with zero
>>>> workers", task->name());
>>>>     uint old_num_workers = _active_workers;
>>>>     update_active_workers(num_workers);
>>>> -  guarantee(_active_workers == num_workers, "active workers %u
>>>> num_workers %u", _active_workers, num_workers);
>>>>     _dispatcher->coordinator_execute_on_workers(task, num_workers);
>>>>     update_active_workers(old_num_workers);
>>>>   }
>>>>
>>>> "num_workers" was 2 and the update_active_workers() failed to create
>>>> an
>>>> additional thread so "_active_workers" remained at 1.  I deleted the
>>>> guarantee.
>>>>
>>>> http://cr.openjdk.java.net/~jmasa/8159073/webrev_delta_03_04/
>>>    looks good.
>>>
>>> Thomas
>>>
>>
>



More information about the hotspot-gc-dev mailing list