RFR (XS): 8078673: Update TEST.groups for recent GC tests

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Tue Mar 1 15:48:10 UTC 2016


Hi Derek,

The fix looks good.

Thanks,
Dima

On 01.03.2016 18:29, Derek White wrote:
> Thanks Thomas!
>
> Looking for 1 more...
>
> On 3/1/16 9:51 AM, Thomas Schatzl wrote:
>> Hi,
>>
>> On Tue, 2016-02-23 at 11:41 -0500, Derek White wrote:
>>> [RFR back from the dead...]
>>>
>>> I think last webrev for this was updated to follow the consensus
>>> opinion, but it never received thumbs up/down from reviewers.
>>>
>>> I've created a new webrev for critical copyright notice updates.
>>>
>>> Summary:
>>> 1) Updated the "needs_g1gc" list in TEST.groups to prevent G1 tests
>>> running in embedded.
>>> 2) Added appropriate "@requires vm.gc" annotations to a few GC tests
>>> that use the process builder and pass in a collector explicitly. The
>>> new @requires annotations prevent unexpected GC-specific tests
>>> running when a conflicting collector argument is specified by the
>>> outer test harness.
>>>
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8078673
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~drwhite/8078673/webrev.04/
>> Looks fine to me.
>>
>> Thomas
>



More information about the hotspot-gc-dev mailing list