RFR (M): 8141141: Young and Old gen PLAB stats are similar in output with -XX:+PrintPLAB

Thomas Schatzl thomas.schatzl at oracle.com
Wed Mar 2 10:47:56 UTC 2016


Hi Stefan,

On Wed, 2016-03-02 at 11:17 +0100, Stefan Johansson wrote:
> Hi Thomas,
> 
> On 2016-03-01 18:35, Thomas Schatzl wrote:
> > Hi all,
> > 
> >    can I get reviews for the following change that tries to improve 
> > PLAB logging output.
[...]
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8141141
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8141141/webrev/
> I agree, a big improvement. Looks good in general, just a few lines
> with 
> wrong indentation in TestPLABPromotion.java:
> 
> 223 for (Map.Entry<String, Long> e: survivorStats.entrySet()) {
> 224 System.err.println(e.getKey() + "@" + e.getValue());
> 225 } --- No need to see an updated webrev. Thanks, Stefan

Oops, that's actually debug code that I intentionally indented wrongly
to find it later more easily... I will just remove it.

Thanks for the review.

Thomas



More information about the hotspot-gc-dev mailing list