RFR 8146991: Introduce per-worker preserved mark stacks in ParallelGC

Srinivas Ramakrishna ysr1729 at gmail.com
Tue Mar 8 19:51:57 UTC 2016


I had a look at webrev.2 below, and the changes look good to me.

Reviewed!
- ramki  (openjdk: ysr)

On Mon, Mar 7, 2016 at 4:03 AM, Thomas Schatzl <thomas.schatzl at oracle.com>
wrote:

> Hi,
>
> On Fri, 2016-03-04 at 17:52 +0100, Thomas Schatzl wrote:
> > Hi,
> >
> > On Fri, 2016-03-04 at 11:14 -0500, Tony Printezis wrote:
> > > Thomas,
> > >
> > > I confirmed that the code below was incorrect and doing the
> > > addition
> > > before calling restore() fixes the issue. Latest webrev here:
> > >
> > > http://cr.openjdk.java.net/~tonyp/8146991/webrev.2/
> > >
> >
> >   looks good to me. JPRT has been fine, although I messed up running
> > the other tests - I forgot to specify ParallelGC as collector to use.
> >
> > I will redo that on Monday. I do not expect any issues.
>
> Looks all good. I will wait one or two days to push for any potential
> additional reviews.
>
> Thanks,
>   Thomas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20160308/612cf0e2/attachment.html>


More information about the hotspot-gc-dev mailing list