JDK-8151514: Remove the noisy NOISY debugging code from parCarTableModRefBS.cpp

Bengt Rutisson bengt.rutisson at oracle.com
Wed Mar 9 13:03:34 UTC 2016


Hi Thomas,

On 2016-03-09 14:03, Thomas Schatzl wrote:
> Hi Bengt,
>
> On Wed, 2016-03-09 at 13:54 +0100, Bengt Rutisson wrote:
>> Hi everyone,
>>
>> Could I have a couple of reviews for this change?
>>
>> http://cr.openjdk.java.net/~brutisso/8151514/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8151514
>>
>> In CardTableModRefBSForCTRS::process_chunk_boundaries() there is a
>> NOISY
>> definition to log some debug messages.
>>
>> Several problems with this macro:
>> * The code inside process_chunk_boundaries() is very hard to read due
>> to
>> all the NOISY lines.
>> * The logging is done to tty and not the logging framework-.
>> * At some point someone detected a conflict with a preprocessor flag.
>>
>> It is better to remove this macro and just add relevant logging if we
>> every find the need for it.
>    agree. Looks good.

Thanks for looking at this!

Bengt

>
> Thomas
>



More information about the hotspot-gc-dev mailing list