RFR: JDK-8151604: Rely on options range checking rather than explict checks
derek.white at oracle.com
Thu Mar 10 16:03:41 UTC 2016
On 3/10/16 4:59 AM, Bengt Rutisson wrote:
> Hi everyone,
> Could I have a couple of reviews for this change?
> With the new range checking in the argument parsing we don't need to
> have explicit checks in the code to handle invalid arguments.
Great idea. Only comment is that this can go further (I only checked
- Line 186, can change tests of MaxGCPauseMillis to guarantee(), because:
- Line 192, can change tests of GCPauseIntervalMillis to guarantee(),
OK, this doesn't have a range defined, but it should:
The checks from lines 220-228 are probably covered by the constraint
functions (MaxGCPauseMillisConstraintFunc(), etc), but this RFE is about
- Line 293, can change tests of SurvivorRatio to guarantee(), because:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev